Oracle Identity: Replace trigger by Generated by#142
Merged
JaBistDuNarrisch merged 19 commits intomasterfrom Oct 30, 2025
Merged
Oracle Identity: Replace trigger by Generated by#142JaBistDuNarrisch merged 19 commits intomasterfrom
JaBistDuNarrisch merged 19 commits intomasterfrom
Conversation
added 10 commits
October 22, 2025 09:02
… loader for oracle
added 8 commits
October 29, 2025 22:16
rjanisch
approved these changes
Oct 30, 2025
Schlupp77
reviewed
Nov 5, 2025
Schlupp77
left a comment
Schlupp77
left a comment
There was a problem hiding this comment.
Keine funktionellen Fehler gefunden, nur ein paar Optimierungen/Fragen.
| sb.AppendLine(" c_pk.TABLE_NAME AS PARENT_TABLE,"); | ||
| sb.AppendLine(" col_pk.COLUMN_NAME AS PARENT_COLUMN"); | ||
| sb.AppendLine("FROM "); | ||
| sb.AppendLine(" USER_CONS_COLUMNS a "); |
There was a problem hiding this comment.
"a" bitte in "ucc" ändern wie weiter unten.
| if (column.Precision.HasValue || column.Scale.HasValue) | ||
| { | ||
| type = GetTypeNameParametrized(column.Type, column.Size, column.Precision ?? 0, column.Scale ?? 0); | ||
| } |
There was a problem hiding this comment.
Microoptimierung, aber könnte man den "if" nicht zuerst machen?
| (oldColumn.MigratorDbType == MigratorDbType.Int16 || | ||
| oldColumn.MigratorDbType == MigratorDbType.Int32 || | ||
| oldColumn.MigratorDbType == MigratorDbType.Int64 || | ||
| oldColumn.MigratorDbType == MigratorDbType.Decimal) && |
There was a problem hiding this comment.
Fehlen hier noch die unsigned Versionen der Typen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #143